feat: multiple consistency levels for authz checks #832
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
kushsharma
force-pushed
the
sdb-token
branch
from
be6a5c1 to
32fe356
Compare
So far frontier was either using no consistency level from spicedb which defaults to prioritise minimum latency with minimal consistent results as well. Other was fully consistent calls which provide the most accurate authz resolution but takes substential latency hit. A middle ground is introduced now that caches the zookie generated during the last fully consistent check and uses that in all but Check calls. This should speed up Lookup/List calls for authz. Existing config `fully_consistent` is now deprecated in favor of new consistency level. ``` spicedb: # consistency ensures Authz server consistency guarantees for various operations # Possible values are: # - "full": Guarantees that the data is always fresh although API calls might be slower than usual # - "best_effort": Guarantees that the data is the best effort fresh [default] # - "minimize_latency": Tries to prioritise minimal latency consistency: "best_effort" ``` Signed-off-by: Kush Sharma <[email protected]>
kushsharma
force-pushed
the
sdb-token
branch
from
32fe356 to
ce441ea
Compare
Pull Request Test Coverage Report for Build 12309660899Details
💛 - Coveralls |
rsbh
approved these changes
Dec 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So far frontier was either using no consistency level from spicedb which defaults to prioritise minimum latency with minimal consistent results as well. Other was fully consistent calls which provide the most accurate authz resolution but takes substantial latency hit. A middle ground is introduced now that caches the zookie generated during the last fully consistent check and uses that in all but
Checkcalls. This should speed up Lookup/List calls for authz.The existing config
fully_consistentis now deprecated in favor of a new consistency level.